Skip to content

Add testing for Arm64EC Windows #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Aug 10, 2025

  • Add a CI job for Arm64EC Windows on the new Arm64 Windows 11 runners.
  • Removes the dedicated step to install rustup on the Arm64 Windows 11 runners as it's not included.
  • Disable FP 16 tests, as it's not supported for Arm64EC.
  • Fix disassembling Arm64EC code.

@dpaoliello dpaoliello force-pushed the arm64ec branch 3 times, most recently from 75be3e9 to de507ea Compare August 10, 2025 20:16
@dpaoliello
Copy link
Contributor Author

Had a clean build here: https://github.com/rust-lang/stdarch/actions/runs/16865911732/job/47772786509?pr=1899

Looks like s390x is currently broken in CI.

@dpaoliello dpaoliello marked this pull request as ready for review August 10, 2025 20:21
@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@folkertdev
Copy link
Contributor

Right, we're blocked on #1897. The fix for our issue has been merged and cherry-picked into the next LLVM point release, but we'll have to wait a bit I guess before rust adopts that and we can use it.

@folkertdev
Copy link
Contributor

For context, is the lack of fp16 support something fundamental, or is it a temporary limitation (e.g. in msvc)?

@tgross35
Copy link
Contributor

For context, is the lack of fp16 support something fundamental, or is it a temporary limitation (e.g. in msvc)?

Currently it's a crash in LLVM and MSVC doesn't support it. I'm hoping that llvm/llvm-project#152843 is all that will be needed to make the scalar type work (if so, we can probably consider stabilizing it after we get LLVM22). If so, AIUI there shouldn't be any problem with these intrinsics.

@folkertdev folkertdev closed this Aug 20, 2025
@folkertdev folkertdev reopened this Aug 20, 2025
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good!

The line noise is a bit unfortunate, but it looks like we're on track to remove the cfgs in the future.

@folkertdev folkertdev added this pull request to the merge queue Aug 20, 2025
Merged via the queue into rust-lang:master with commit e556386 Aug 20, 2025
80 of 127 checks passed
@dpaoliello dpaoliello deleted the arm64ec branch August 20, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants