Remove rustfmt.toml, update rustfmt lint to 2024 edition #2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh ok, that was fast :^) |
|
I would recommend keeping this file, but updating it to 2024. Some editors call |
|
ah sorry I didn't consider that! Thanks for the suggestion Eric, let me fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From comment.
I'm curious to see what happens if we remove the
rustfmt.tomlfile that is forcing code linting to edition 2018. Running cargo fmt locally and picking the edition (2024) fromCargo.tomldoes not produce any linting errors.Let's see here what says the CI ...