Accept/decline T-compiler backports from Zulip #2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
changed the title
apiraino
changed the title
apiraino
force-pushed
the
accept-backports-from-zulip
branch
from
a42cf9d to
b265ac9
Compare
apiraino
changed the title
apiraino
commented
Aug 13, 2025
| }, | ||
| content: "", | ||
| }; | ||
| let zulip_link = zulip_send_req.url(zulip_client); |
There was a problem hiding this comment.
Note: for how the Message API works today, we can't pin exactly a single message so the link in the GitHub comment will be to the whole topic, which is a bit inconvenient but hopefully will be solved by Zulip. I'd rather wait on them for a correct fix rather us add hacks to make it work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new Zulip command:
@triagebot backport <channel> <action> <PR>Example:
@triagebot backport stable accept 123456@triagebot backport beta decline 654321This can be used to post on GitHub a comment like this one when T-compiler accepts/decline to backport a patch that fixes a regression.
Limitations:
rust-lang/rust, I am not aware of other git repos having this workflow. If we want, maybe in the future we can extend to other repos using our custom Zulip linkfiersTested on a custom Zulip instance.
TODO:
backport acceptor evenaccept) to be used from#t-compiler/backports(topics contain all necessary info to build the command parameters)