feat!: update ServerHandler and ServerHandlerCore traits #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR refactors the signature of handler functions in
ServerHandlerandServerHandlerCoreto accept an Arc instead of a &dyn McpServer.This PR also refactors the start function in
server_runtime.rsto prevent the stream loop from being blocked by handle_message calls.✨ Changes Made
Arc<dyn McpServer>instead of a&dyn McpServeron_server_startedin favor ofon_initialized⚠ BREAKING CHANGE:
ServerHandlerandServerHandlerCorefunctions must update their signatures to acceptArc<dyn McpServer>instead of&dyn McpServeron_initialized()should be used instead ofon_server_started()