Skip to content

Add support for ip addr add <IP> peer <PEER_IP> #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for ip addr add <IP> peer <PEER_IP> #77

wants to merge 1 commit into from

Conversation

sebastianmarines
Copy link

This pull request adds support for specifying a peer IP address when adding an IP address. If a peer address is provided, it will be used instead of the local IP for the IFA_ADDRESS attribute.

cathay4t
cathay4t requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's postpone this as it is breaking API.

I am thinking of use Builder stuff like 230a729 , otherwise we will have to break API every time a new property introduced to IP address.

@cathay4t
Copy link
Member

The builder changes has merged. Please adapt to the new workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t cathay4t requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Wait_Submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianmarines @cathay4t