Skip to content

Conversation

sebastianmarines
Copy link

This pull request adds support for specifying a peer IP address when adding an IP address. If a peer address is provided, it will be used instead of the local IP for the IFA_ADDRESS attribute.

Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's postpone this as it is breaking API.

I am thinking of use Builder stuff like 230a729 , otherwise we will have to break API every time a new property introduced to IP address.

@cathay4t
Copy link
Member

The builder changes has merged. Please adapt to the new workflow.

@cathay4t
Copy link
Member

cathay4t commented Sep 8, 2025

ping

@sebastianmarines
Copy link
Author

Won't work on this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants