Skip to content

Bump the MSRV to 1.85 #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bump the MSRV to 1.85 #1653

wants to merge 4 commits into from

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Aug 12, 2025

  • Added a CHANGELOG.md entry

Summary

Bump the MSRV to 1.85 (except rand_chacha which we plan to replace).

Motivation

#1642 requires this MSRV bump. #1632 requires at least 1.75.

@dhardy dhardy requested a review from newpavlov August 12, 2025 13:13
@dhardy dhardy force-pushed the push-tpslkyqlosnn branch from 81ad512 to 74226cb Compare August 12, 2025 13:59
@benjamin-lieser
Copy link
Member

benjamin-lieser commented Aug 13, 2025

Should this also be in a 0.9.x version? I guess not, seeing the changelogs.
I would say 1.85 is a bit too recent for a patch update.

Are we planning for a 0.10 release of rand_core? I understood it we want to release rand 0.10 with rand_core 0.9 and not have rand_core 0.10 for now.

@dhardy
Copy link
Member Author

dhardy commented Aug 13, 2025

Should this also be in a 0.9.x version? I guess not, seeing the changelogs.

No, this is for v0.10. I wanted to make a pre-release using chacha20, but we may not be ready to do that yet.

Are we planning for a 0.10 release of rand_core? I understood it we want to release rand 0.10 with rand_core 0.9 and not have rand_core 0.10 for now.

Good point.

So should we keep the old MSRV for rand_core (and maybe some of the other crates)? I guess then we should... which means that we need two CI paths for MSRV tests.

### Changes
- Bump the MSRV to 1.85 (#1653)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also worth to mention the edition bump.

@newpavlov
Copy link
Member

So should we keep the old MSRV for rand_core (and maybe some of the other crates)?

Probably, yes. It would allow us to explicitly relax the MSRV policy to allow MSRV bumps in patch releases because of the MSRV-aware resolver. It may be even worth to release getrandom v0.4, not only to relax MSRV policy, but also to remove the built-in Web WASM support in favor of the custom fallback approach.

@dhardy
Copy link
Member Author

dhardy commented Aug 14, 2025

@newpavlov how does keeping some crates on rustc 1.63 help us relax the MSRV policy? The new resolver isn't available until 1.84.

No comment on getrandom here except that the plan is to not make a breaking release of rand_core for now, hence we'd have to evaluate whether upgrading to getrandom v0.4 would be a breaking change for users of rand_core.

@newpavlov
Copy link
Member

Sorry, I misread your comment. I thought you suggested to cut new releases of rand_core with MSRV bumped to 1.85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants