Remove const-generic size parameter from Dirichlet distribution #30
Conversation
…wing it to be used with a dynamic number of parameters
|
So we want to remove the const generic version? |
|
I don't really have a preference here — but is there a use-case for the const-generic version? |
|
I don't think at the moment, if there is they can make a PR I guess. |
src/multi/dirichlet.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Construct a new `Dirichlet` with the given shape parameter `alpha` and `size`. |
There was a problem hiding this comment.
Do we really need this? new(&vec![alpha;size]) does the same thing, and probably is not really slower.
There was a problem hiding this comment.
This came from #15. I guess it doesn't add much.
A specialised implementation for this would be more useful, saving memory and an allocation in the constructor.
|
is there any release expected in the horizon? I cant use the current const version |
|
I'll make a pre-release as soon as #31 is approved. v0.6 final might not be so soon — we may make a new |
|
@barakugav I published the pre-release |
3 participants
I rebased #15 (non-trivial). It compiles and passes tests but might warrant a better review.
CC @MortenLohne