Skip to content

cap: add KvmCapStealTime capability #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cap: add KvmCapStealTime capability #239

wants to merge 1 commit into from

Conversation

xuejun-xj
Copy link
Contributor

This capability is used for kvm steal time feature.

Docs for KVM_CAP_STEAL_TIME

roypat
roypat reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there's value in adding testing similar to https://github.com/bchalios/kvm-ioctls/blob/0177432e14e697db0d88a1dd753179d639b9e4c2/src/ioctls/vcpu.rs#L2789-L2806?

CHANGELOG.md Outdated
Comment on lines 8 to 9
- [[#239](https://github.com/rust-vmm/kvm-ioctls/pull/239)] cap: add KvmCapStealTime
capability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: In 0.15.0 we phrase capability addition as "Add Cap::KvmCapStealTime capability". Could we keep these consistent? :o

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks. I will fix later.

@xuejun-xj
Add Cap::KvmCapStealTime capability
de24816 
This capability is used for kvm steal time feature.

Signed-off-by: xuejun-xj <[email protected]>
@xuejun-xj
Copy link
Contributor Author

xuejun-xj commented Oct 13, 2023 •
edited
Loading

Do you think there's value in adding testing similar to https://github.com/bchalios/kvm-ioctls/blob/0177432e14e697db0d88a1dd753179d639b9e4c2/src/ioctls/vcpu.rs#L2789-L2806?

Hi @roypat! Thanks for the reminder. I have add a test case(test_kvm_steal_time_capability) for aarch64. Is there anyone can help me to add test case for x86_64? According to the docs, it may be initialized with another path on x86_64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypat roypat roypat left review comments

@acatangiu acatangiu Awaiting requested review from acatangiu acatangiu is a code owner

@alxiord alxiord Awaiting requested review from alxiord

@andreeaflorescu andreeaflorescu Awaiting requested review from andreeaflorescu andreeaflorescu is a code owner

@lauralt lauralt Awaiting requested review from lauralt lauralt is a code owner

@sameo sameo Awaiting requested review from sameo sameo is a code owner

@JonathanWoollett-Light JonathanWoollett-Light Awaiting requested review from JonathanWoollett-Light

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuejun-xj @roypat