mshv-ioctls: rename variables for proc & xsave features #283
+41
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables denote *disabled* processor/xsave features. Name them as such for better readability. Otherwise it is confusing why feature bits are being set to 0 in order to enable them. Signed-off-by: Anirudh Rayabharam <[email protected]>
anirudhrb
requested review from
NunoDasNeves,
gamora12,
liuw,
praveen-pk,
russell-islam and
skinsbursky
as code owners
|
Do you know why CLH build is failing? |
Looks same as that issue where we also need to bump vfio crates along with mshv. |
russell-islam
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These variables denote disabled processor/xsave features. Name them as such for better readability. Otherwise it is confusing why feature bits are being set to 0 in order to enable them.
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.