-
Notifications
You must be signed in to change notification settings - Fork 103
virtio-queue: add verify_add_used and stub memory region #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
959d811
to
7113f45
Compare
96d3228
to
89e9614
Compare
89e9614
to
7f83b55
Compare
7f83b55
to
f8c3526
Compare
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please for the commit description, follow the style of other commits, using the crate as prefix, something like this:
virtio-queue: add unit proof for add_used method (sec 2.8.22)
f8c3526
to
433129f
Compare
7f83b55
to
6451a84
Compare
Kani proofs do not finish in practical time if we use the production memory region. So we implement a stub region with a simple vector backing it. This will help subsequent proofs work and also enable stateful proofs. Signed-off-by: Siddharth Priya <[email protected]>
6451a84
to
a0bdc34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments from my side. LGTM but I'd like an approval from @MatiasVara and @roypat
and @epilys |
Signed-off-by: Siddharth Priya <[email protected]>
Signed-off-by: Siddharth Priya <[email protected]>
a0bdc34
to
2bda53f
Compare
Summary of the PR
virtio-queue: add verification for
add_used
operationKani proofs like
verify_add_used
do not finish in practical time if we use the production memory region. So we implement a stub region with a simple vector backing it. This will help subsequent proofs work and also enable stateful proofs.Note that
unsafe
code is added only for StubRegion that will run in Kani.Kani verifies all
unsafe
accesses do not cause undefined behaviour (in the context of unit proof execution).Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.