0.3 backports #192
Merged
0.3 backports #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to reset the age of the *new* front buffer to 1, not the old one. It turns out they're easy to mix up right when you're about to swap them. Cherry-picked from `master` to 0.3.
Drm-rs now no longer requires separate generated bindings for each platform, so this fixes the build on architectures/OSes where drm didn't have bindings. It also now uses Rustix instead of Nix, but Nix is still used by the Wayland and X11 backends, until the next wayland-rs and x11rb release. This is not a breaking change since `drm` isn't exposed in the API. Cherry-picked from `master` to 0.3.
ids1024
force-pushed
the
0.3-backports
branch
from
dafd2ed to
5c7daf1
Compare
|
Okay, I think #180 isn't needed since some of the code around that is different between 0.3 and 0.4, and on 0.3 |
Merged
notgull
approved these changes
Jan 11, 2024
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new 0.3 release is useful for anything still relying on raw-window-handle 0.5. Given it isn't too hard. In particular iced-rs/iced#2190.
Is #180 also needed here? Or was that issue introduced later? Easy enough to add.
Leaving as a draft until I test on macOS (and make sure nothing has buffer age bugs now?). And we should also do a 0.4.x release with the current fixes.