Add cross-platform custom decorations (titlebar-less) + platform titlebar demo + small fixes#4450
Open
JakkuSakura wants to merge 4 commits intorust-windowing:masterfrom
Open
Add cross-platform custom decorations (titlebar-less) + platform titlebar demo + small fixes#4450JakkuSakura wants to merge 4 commits intorust-windowing:masterfrom
JakkuSakura wants to merge 4 commits intorust-windowing:masterfrom
Conversation
3941cdc to
4439550
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the “custom titlebar / custom decorations” story end-to-end: it adds two examples, fills in a missing backend capability (X11 window menu), and fixes a macOS
crash when toggling decorations.
What’s in this PR
Backend/library changes
Why this is necessary
lose access to the system menu.
window-menu APIs.
How to test
Notes / Limitations
closes #3664
related to #4100, but my focus in on MacOS and adds examples. I'm fine merging the code and test if either is merged first