Open
Conversation
Winit only supports text, thus we should ignore the rest instead of crashing.
kchibisov
force-pushed
the
kchibisov/release-03013
branch
3 times, most recently
from
b440e5d to
a42e8a7
Compare
The xfixes implementation is not that reliable and rather simple to replace, so use x11rb to implement the same functionality. Fixes #4120. Co-authored-by: avitran0 <holyhades64@gmail.com>
macOS native Pinyin IME can send a selected_range that exceeds the marked text string length (e.g. index 8 for a 6-character string). This caused an NSRangeException in substringToIndex:, crashing the application with SIGABRT. Clamp both location and end to the string's UTF-16 length before calling substringToIndex.
kchibisov
force-pushed
the
kchibisov/release-03013
branch
3 times, most recently
from
86ac487 to
c59ae7c
Compare
kchibisov
force-pushed
the
kchibisov/release-03013
branch
from
c59ae7c to
f64a342
Compare
madsmtm
approved these changes
Mar 1, 2026
Member
|
Looking at this, I thought I missed a PR after initially fixing something on "our" old 0.29 backport branch which we're still using... But turns out I never PR'd this: #4499 Would it make sense to backport it to 0.30 too? Might be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.