Skip to content

Conversation

@PLeVasseur
Copy link
Collaborator

Closes #145

@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for scrc-coding-guidelines failed.

Name Link
🔨 Latest commit 25cae3b
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/68f9476e6906ee0008bc5223

@PLeVasseur PLeVasseur force-pushed the feature/coding-guidelines-goals branch from 99c4170 to 863169b Compare July 14, 2025 21:32
@felix91gr
Copy link
Collaborator

@PLeVasseur do you want me to take a look at this? :)

@PLeVasseur
Copy link
Collaborator Author

That'd be very kind of you ;D

Copy link
Collaborator

@felix91gr felix91gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you're ready for many comments <3

@felix91gr felix91gr added the documentation Improvements or additions to documentation label Aug 11, 2025
Copy link
Collaborator

@felix91gr felix91gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions are now in place ^^

PLeVasseur and others added 7 commits September 17, 2025 04:51
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
@PLeVasseur PLeVasseur force-pushed the feature/coding-guidelines-goals branch from 59cb10c to 4f0f9fe Compare September 16, 2025 19:51
@PLeVasseur PLeVasseur force-pushed the feature/coding-guidelines-goals branch from 7f7e285 to 7c89bd9 Compare September 16, 2025 21:26
@PLeVasseur PLeVasseur force-pushed the feature/coding-guidelines-goals branch 2 times, most recently from 46d94f8 to 494cbda Compare September 16, 2025 22:54
@PLeVasseur PLeVasseur force-pushed the feature/coding-guidelines-goals branch from 494cbda to ff367d1 Compare September 16, 2025 22:56
@PLeVasseur PLeVasseur changed the title Add GOALS.md, freshen up to use arewesafetycriticalyet.org Add GOALS.md, revise contribution process, freshen up to use arewesafetycriticalyet.org Sep 16, 2025
@PLeVasseur PLeVasseur requested a review from felix91gr October 6, 2025 19:44
Copy link
Collaborator

@felix91gr felix91gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long diffs. My bad.

Also I really like how the Contributing document is shaping up!

I hope my suggestions make sense x3

GOALS.md Outdated
* We include a rationale with links to parts of the Rust Project and wider Rust community for guidance
* We will include linkage where appropriate to to various standards, e.g. CERT C, MISRA C, DO 178, ISO 26262
* We will include practical recommendations on how to use this piece of the language using compliant and non-compliant examples
* We will develop an addendum matrix to reduce burden of attaching these later
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, do you mean that we will...

  1. Develop an addendum matrix to help reduce the burden of later attaching these guidelines?,
  2. or do you mean that we will... develop an addendum matrix later, to reduce the burden of attaching these guidelines?

I hope that makes sense. I read it and I'm not 100% sure which of those we mean.

Copy link
Collaborator Author

@PLeVasseur PLeVasseur Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, do you mean that we will...

  1. Develop an addendum matrix to help reduce the burden of later attaching these guidelines?,
  2. or do you mean that we will... develop an addendum matrix later, to reduce the burden of attaching these guidelines?

I hope that makes sense. I read it and I'm not 100% sure which of those we mean.

The intent is for this to mean:

  1. Develop an addendum matrix to help reduce the burden of later attaching these guidelines to your safety-critical software development process

The idea being that by having such a matrix we

  1. make clear which safety standards we currently support
  2. and how

for any potential users.

Happy to take suggestions on rephrasing or I'll do so.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked this in bdfc48a

How does this look?

GOALS.md Outdated
* We will include linkage where appropriate to to various standards, e.g. CERT C, MISRA C, DO 178, ISO 26262
* We will include practical recommendations on how to use this piece of the language using compliant and non-compliant examples
* We will develop an addendum matrix to reduce burden of attaching these later
* We will begin with DO 178 and ISO 26262 at perhaps chapter level, maybe subsection level _for now_ and expand later
Copy link
Collaborator

@felix91gr felix91gr Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also feels a bit ambiguous. Are we intending to...

  1. Begin with DO 178 and ISO 26262 for now and expand upon others later?, or
  2. are we intending to cover those two, beginning at either their chapter level or their subsection level, and if we begin at the latter, then we intend to expand towards the chapter level later?

I hope that makes sense as well. This one line feels a bit loose in the context of everything else.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended to mean both bullet points. Perhaps it should be broken into two bullet points then, since it seems it may aid in understanding.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked this in bdfc48a

How does this look?

GOALS.md Outdated
* We aim to produce evidence-based guidelines, with statistics around human error when programming Rust, to support:
1. What guidelines are written, and
2. Why a specific suggestion was made
* We will produce the guidelines in an artifact that's easily machine readable and consistent format to make it easier to consume by tool vendors to some minimal viable artifact.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* We will produce the guidelines in an artifact that's easily machine readable and consistent format to make it easier to consume by tool vendors to some minimal viable artifact.
* We will produce the guidelines in an artifact that's easily machine readable and of a consistent format, to make it easier to consume by tool vendors to some minimal viable artifact.

This one is hard to parse. I assumed there's a missing "of a" and a missing comma in the middle.

But I'm still not 100% sure what we mean here.

  1. An artifact that's easily machine readable, got it, perfect.
  2. Of a consistent format, nice.
  3. (1) and (2) are there so that these are easier to consume by tool vendors. Awesome.
  4. ... but then we say "to some minimal viable artifact". Maybe it was "to some minimally viable artifact", but I'm still not sure what that means in the context of everything else.

Maybe this needs to be split into multiple sentences? Maybe multiple bullet points. Whatever we may need to express what we mean to say here, is good :3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give some thought to point 4.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 01e2a2c

GOALS.md Outdated
# Explicit non-goals

* For the initial version to have complete coverage of the Rust programming language
* "Something" shipped to alleviate pressure at organizations is better than "nothing is available" even if we have to heavily subset the language
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if a link to what we mean by "subset the language" would help.

You and I know exactly what we mean by that, and people who have worked with MISRA probably understand the concept as well. But I wonder if other folks who work on Safety Critical know about it too?

Maybe there's a reference we can point to, that explains the concept?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it is better to simply omit the point. It doesn't seem that important to mention the method for shipping something

Suggested change
* "Something" shipped to alleviate pressure at organizations is better than "nothing is available" even if we have to heavily subset the language
* "Something" shipped to alleviate pressure at organizations is better than "nothing is available"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add another bullet point to clarify what I mean and why for subsetting the language. I do think it's important to make this obvious as it's an accepted means of allowing certain parts of the language and not others by IEC 61508 and ISO 26262 (and possibly others).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 25cae3b. Please give this a read-through and let me know.

@PLeVasseur
Copy link
Collaborator Author

Reminder to self to put somewhere that the current only way to retrigger the Netlify action is to submit an empty commit.

I think you may have to push an empty commit to retrigger without actual new code being pushed.
https://answers.netlify.com/t/cant-rerun-failed-netlify-checks-for-github-pr/95725/4

Should find an alternative way to trigger via GitHub if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coding guidelines "north star" document addition to repo

4 participants