[Guideline] Add guideline requiring wrapping unsafe code in safe abstractions #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AchimKriso
commented
Aug 18, 2025
| :category: required | ||
| :status: draft | ||
| :release: - | ||
| :fls: fls_jep7p27kaqlp |
There was a problem hiding this comment.
This simply references the entire Unsafety chapter of the FLS.
I wasn't able to find anything better, since the FLS is mostly about describing the Rust language itself, instead of how to use it correctly.
|
Hey @AchimKriso 👋 wanted to make sure you saw the feedback I'd left over on #175 (comment). Could you take a look over there and see if you could follow the steps outlined? |
|
Hi @PLeVasseur, I've seen the comment, I'll try to get to it this or one of the next days. |
|
Created #192. Closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #175, this is a low hanging fruit of a guideline.
While there aren't analogous guidelines for CERT or MISRA (as far as I know) this is mostly due to the fact that C or C++ do not have the same safe-unsafe split.
Still, without this rule the whole concept of safe Rust becomes meaningless.