Parser bug fixes #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chifflier Just wanted to ping you to see if I can get q review on this and my other pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I have identified 3 Ike Payloads that have bugs in their parser implementations.
NotifyandDeleteseem to assume the length passed to them doesn't have the 4 bytes for the header removed.Vendor IDseems to be trying to skip over some other data in addition to the header.I committed fixes to each of the 3 parsers and added unit tests that capture the error I was correcting. Let me know if there is any other information or code changes you'd like to see in this MR.