webidl: webgpu: make the size argument to copyBufferToBuffer optional
#4508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@daxpedda apologies for the ping, do you have a minute to review this? Excluding the generated code, it's a very small change, and having it upstream helps us to avoid tracking local changes to our vendored copy. Thanks! |
guybedford
approved these changes
Aug 6, 2025
daxpedda
requested changes
Aug 6, 2025
daxpedda
reviewed
Aug 8, 2025
daxpedda
force-pushed
the
buf-to-buf-copy-size
branch
from
9740e9a to
36b0927
Compare
daxpedda
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the latest spec.
There is also a 3-argument overload of
copyBufferToBuffer, which I have not added, as it poses some additional challenges, and I do not immediately need it.See https://www.w3.org/TR/webgpu/#commands-buffer-copies for context for the following explanation.
The logic in wasm-bindgen that generates unique names for the different overloads does not understand that the 3-argument overload is omitting the 2nd and 4th arguments to the 5-argument overload. So it generates names based on every argument starting with the 2nd, which (1) changes existing names for variants of the 5-argument overload, (2) includes
with_gpu_bufferfor the 3rd argument in the names even though that has no actual disambiguation purpose.