This repository was archived by the owner on Mar 29, 2024. It is now read-only.
Open
Conversation
the generate_ssl.sh script was only generating the .key files, not the .crt too. Modified it to create both. There are probably other ways of doing this too.
rootless4real
commented
Sep 29, 2018
Author
rootless4real
left a comment
rootless4real
left a comment
There was a problem hiding this comment.
the apache2 config you are using specifies certificate.key and certificate.crt rather than server.key and server.crt, so I updated this again to match that syntax.
Owner
|
Hi, Thank you for the PR, though there are other tasks that has to be done before merging it. As you changed the extensions of files you forgot to propagate this though code and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the generate_ssl.sh script was only generating the .key files, not the .crt too. Modified it to create both. There are probably other ways of doing this too.