Skip to content

fix no setter fileStore name #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thammel wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix no setter fileStore name #49

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
452a2ef
Add setter for name attribute
thammel Nov 3, 2025
9d5821a
Enhance name setter to validate input and handle file renaming
thammel Nov 4, 2025
4bda8c7
Refactor file renaming logic to use new 'rename_file' function
thammel Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions aas_editor/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,23 @@ def name(self):
else:
return f"/{self._filePath.name}"

@name.setter
def name(self, new_name: str):
if not isinstance(new_name, str) or new_name.strip() == "":
raise TypeError("new name must be a non-empty string")

if self.savedInStore():
new_stored_name = self._fileStore.rename_file(self.name, new_name)
self._name = new_stored_name
else:
if self._filePath is None:
raise ValueError("No local file path available to rename")
new_path = self._filePath.parent.joinpath(new_name)
if new_path.exists():
raise FileExistsError(f"Target file already exists: {new_path}")
self._filePath.rename(new_path)
self._filePath = new_path

@property
def mime_type(self) -> str:
if self.savedInStore():
Expand Down