Repository navigation
Conversation
kavemang
marked this pull request as ready for review
October 11, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
BackupSettingsCodecTestexercised a duplicate ZIP writer that no production export called. Route AndroidexportTothrough the context-free stream writer and test the same archive construction used at runtime.The copy stays inside the existing Room write transaction and output-stream scope. The writer returns the copied database byte count used for restore-ceiling warnings, preserves database/settings/manifest entry order, and finishes the ZIP before verification. Tests cover exact UTF-8 manifest/settings payloads, a readable central directory, database-only byte accounting, legacy and manifest-only shapes, restore round-trips, and propagated output failures with cleanup.
Android-only JVM/SAF extraction: the container entries, settings whitelist, provenance payload and database schema are unchanged; no Swift storage or analytics change is needed. Required derived parity metadata accompanies the production call-graph change.
Type of change
How it was tested
BackupSettingsCodecTestmethods and the changedBackupSyncFileIoTestarchive round-trip pass against extracted production writer/staging/codec code, real ZIP/file I/O and JSON, with verbatim production entry-name and hosted-card constants. This does not compile Android Context/Room/SAF or exercise a live database transaction.d1c1abc9ff7644bf63dc418761359ae01f81c17d, Android CI compiled the complete app and built the debug APK (4m 35s), then passed the fulltestFullDebugUnitTestsuite (1m 53s). No warnings name the changed production or test files. Individual JVM test counts are not emitted by this workflow.Checklist
docs/CONTRIBUTING.mdRelated issues
Refs #2708