simplify cmake, update workflow, add appletLockExit#19
Open
ITotalJustice wants to merge 2 commits into
Open
Conversation
Owner
|
Hey! Just wanted to say I appreciate you taking a look! I'll take a closer look and build myself + test as soon as I get the chance :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi! i saw your issue at #2 and thought i'd help.
I've simplified the cmake quite a bit, and tried to keep it inline with upstream, should you ever want to upstream the switch port.
i removed some of the files that you added for the switch port, such as fpattern source and a couple of cmake files.
i also removed the stray
nsInitialize()andfsInitialize(). fs is automatically init upon startup, and i can't see anywhere ns is used so i removed it. sdmc is also automatically mounted.userAppInit()is called beforemain(), typically you'd add all service inits here.userAppExit()is called when main exits, you'd add all service de-inits here.appletLockExit()blocks the game from closing (when using the home menu to close the application) untilappletUnlockExit()is called. This allows for a clean exit and removes the risk of corrupting files, should the user try to close the game whilst a file is being written to.to build:
the debug (dev) build doesn't compile due to missing symbols, i didn't try to fix them.
NOTE: i haven't actually tested any of this code - i don't own fallout 😄 please let me know if anything broke, or need further help 👍🏼