This repository was archived by the owner on Dec 1, 2019. It is now read-only.
Added error handling in case if reading tsconfig fails #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le0Michine
force-pushed
the
handle-tsconfig-reading-failure
branch
from
d1f1f16 to
c517d4a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error when was trying to setup typescript for an existing project:
Cannot read property 'compilerOptions' of undefined
After spending some time debugging I found out that current implementation doesn't check
readConfigFileoutput and just passes it toparseJsonConfigFileContentwhich tries to accesscompilerOptionsproperty. In this PR I added some error handling logic to let users know about the actual error in case if there is an issue with their tsconfig file.