Skip to content

Conversation

@largewedge
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Fixed CDB field lookup name (changed from sepd_calib to mip_calib), changed CDB lookups to use encoded keys instead of channel number, moved cdbttree lookup to InitRun(), and added bad/uncalibrated channel handling.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

…hanged CDB lookups to use encoded keys instead of channel number, moved cdbttree lookup to InitRun(), and added bad/uncalibrated channel handling.
@pinkenburg pinkenburg marked this pull request as draft August 11, 2025 13:15
@pinkenburg pinkenburg requested a review from eumaka August 11, 2025 13:15
@eumaka
Copy link
Contributor

eumaka commented Aug 11, 2025

Have you tested these changes against run2auau? Please update your calibration file to use the same structure as previous runs, there is really no need to change things now. Setting a channel to zero artificially based on your fit/calibration factors is dangerous. I would recommend dividing by the average MPV, then use m_TowerInfoContainer_calib->get_tower_at_channel(ch)->set_isNoCalib(true); or other status setters to mark that channel.

@pinkenburg
Copy link
Contributor

Whatever is implemented it has to work across our runs, we don't want separate schemes for run2auau and run3auau.

@pinkenburg pinkenburg closed this Aug 15, 2025
@pinkenburg pinkenburg reopened this Aug 15, 2025
@pinkenburg
Copy link
Contributor

This PR would break the existing Run2 production and after inserting a reformatted calibration which is compatible with the existing code this PR is not needed anymore

@pinkenburg pinkenburg closed this Aug 15, 2025
@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit a9a1d929f3f879205bf3af5b3fe4d667502044e1:
Jenkins on fire


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@largewedge
Copy link
Contributor Author

These changes were intended to be a short-term fix only to be used for run3 AuAu calibrations. See PR #3828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants