Skip to content

Conversation

@bogui56
Copy link
Contributor

@bogui56 bogui56 commented Dec 16, 2024

Set Clusterizer to split common mode noise patterns into zsize = 1 clusters and add machinery to reject them in PHCAseeding

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 921e604743be291ba2820bf23d3cbe1cab4efd2b. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@osbornjd osbornjd marked this pull request as draft January 21, 2025 17:25
@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 6b09d9cd04f65b5dab93a658be9e9200042978b6. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@bogui56 bogui56 marked this pull request as ready for review February 13, 2025 15:24
@osbornjd
Copy link
Contributor

Should we add this flag to our reco macros too? Better yet, is it time for us to have a centralized function call for our seeding reconstruction?

@sPHENIX-GitHub-l
Copy link

sPHENIX-GitHub-l commented Feb 13, 2025 via email

@osbornjd
Copy link
Contributor

For example we are not currently calling the function Tracking_Reco_TrackSeed() in our reconstruction macros, e.g. here. The seeding may be at a point where it has converged enough to have it a central place, which would also make it such that we would have a consistent set of modules/flags that the macros by default call

@bogui56
Copy link
Contributor Author

bogui56 commented Feb 13, 2025

Ah, that way, well for me that would be ok. Modulo the changed Michael and David will still come up with...

@osbornjd
Copy link
Contributor

It does cause a small loss in efficiency at low pT
https://nbviewer.org/github/sPHENIX-Collaboration/QA-gallery/blob/jenkins-sPHENIX-test-tracking-low-occupancy-qa-6871-test-tracking_Event400_Sum28/QA-tracking.ipynb
but that is probably not an issue right now

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit aba70f9b802fd3c5a8e69889b684b1a671840af0. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants