feat: configure activity to support lock screen access and the Android Notes role intent - #1747
feat: configure activity to support lock screen access and the Android Notes role intent#1747IGS-GIT wants to merge 6 commits into
Conversation
|
Unsure why those tests failed as what I added doesn't affect those features. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
- Coverage 52.22% 51.93% -0.30%
==========================================
Files 131 132 +1
Lines 9395 9415 +20
==========================================
- Hits 4907 4890 -17
- Misses 4488 4525 +37 ☔ View full report in Codecov by Harness. |
|
@cubic review this (I'm trying out AI code reviews. They may or may not be helpful.) |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 2/5
- There is a high-confidence security/privacy risk in
android/app/src/main/AndroidManifest.xml: enablingshowWhenLockedandturnScreenOnon the main activity can expose note content over the lock screen outside the intended CREATE_NOTE flow. - Because this behavior is user-facing and can reveal sensitive data after auto-lock, the change carries clear regression risk and is not a low-risk merge as-is.
- Pay close attention to
android/app/src/main/AndroidManifest.xml- lock-screen visibility flags appear too broadly applied and should be scoped to the intended scenario only.
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
adil192
left a comment
adil192
left a comment
There was a problem hiding this comment.
Unfortunately the AI is right. I see these two issues:
- When you open the notes app from the lockscreen, it opens to the normal home screen of Saber, showing all the user's notes without unlocking. We should restrict the lockscreen behaviour to only create a new note and not reveal any existing notes.
- While using Saber, if you lock the screen or let it timeout, pressing the power button launches you straight into Saber without the lock screen.
|
Ah yeah I did catch that originally. I was planning on reworking it to only allow new notes on the lockscreen. Ive been really busy with finals so I haven't had time to work on it but I'll get some time this weekend to resolve this. Apologies |
|
I'll need to make a new utility class for lock-screen state and platform channel communication. I'll begin the work and make a new commit soon. |
|
I had to rebase because the commit history was getting filled with small fixes that I should've caught the first time. My apologies |
There was a problem hiding this comment.
3 issues found across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
|
I'll wait for confirmation first. Those changes look fine but I don't want to make that call. It's your AI |
|
Do I have to create a new test case for this feature? I'm thinking we'd want to test to make sure the security of the lock screen isn't compromised. |
…d Notes role intent
… dedicated lock screen manager
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…ed navigation logic with tests
2 participants
I added the necessary flags and filters needed to designate Saber as the default note-taking app for Android. It supports Lock Screen Notes and opening the app when pressing a stylus button. Functionality was tested on a Google Pixel Tablet running Android 16 QPR 3 and with an unreleased Pixel Stylus that supports the USI 2.0 protocol. Button is fully functional and the note widget on the lock screen opens up to the home screen of the app. This resolves the following Issue(s):
#1708