Skip to content

chore: Drop support for PHP 7.4#134

Open
DerDreschner wants to merge 1 commit intosabre-io:masterfrom
DerDreschner:chore/drop-php-74
Open

chore: Drop support for PHP 7.4#134
DerDreschner wants to merge 1 commit intosabre-io:masterfrom
DerDreschner:chore/drop-php-74

Conversation

@DerDreschner
Copy link
Copy Markdown

This pull request drops support for PHP 7.4 in order to modernize the library.

Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
Copilot AI review requested due to automatic review settings March 26, 2026 14:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Drops PHP 7.4 support across project configuration to align tooling, CI, and documentation with PHP 8+.

Changes:

  • Update Composer PHP requirement to PHP ^8.0 and pin dev dependency resolution to PHP 8.0 via config.platform.
  • Configure PHPStan to analyze against a PHP 8.0–8.5 target range.
  • Remove PHP 7.4 from CI and update README minimum PHP version for master.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
phpstan.neon Sets PHPStan target PHP version range starting at 8.0.
composer.json Drops PHP 7.4 requirement and pins platform PHP to 8.0 for consistent dependency resolution.
README.md Updates documented minimum PHP version for master to PHP 8.0.
.github/workflows/ci.yml Removes the PHP 7.4 CI job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (a4fd239) to head (1c16720).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files           1        1           
  Lines         174      174           
=======================================
  Hits          170      170           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis
Copy link
Copy Markdown
Contributor

Issue #137
For discussion, what minimum PHP 8.* do we support?

Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we need to decide if we move further forward to minimum PHP 8.2 or?

Comment on lines -20 to -23
- php-versions: '7.4'
coverage: 'none'
code-style: 'yes'
code-analysis: 'yes'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run code-style somewhere.
So change this job from 7.4 to 8.0
And remove 8.0 from the array at line 15.

@phil-davis
Copy link
Copy Markdown
Contributor

I used this code, with needed changes, in #140 to demonstrate supporting just PHP 8.2 and up.

We need to decide what is the minimum PHP version that we want to support now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants