Skip to content

fix: send participation reply on fresh event#743

Merged
ChristophWurst merged 1 commit intosabre-io:masterfrom
SebastianKrupinski:fix/send-reply-on-event-creation
Jan 9, 2026
Merged

fix: send participation reply on fresh event#743
ChristophWurst merged 1 commit intosabre-io:masterfrom
SebastianKrupinski:fix/send-reply-on-event-creation

Conversation

@SebastianKrupinski
Copy link
Copy Markdown
Contributor

@SebastianKrupinski SebastianKrupinski commented Dec 30, 2025

Summary

  • modified parseEvent logic to send participation reply on both object creation (user saves event with participation status set) and object update (user changes participation status)
  • added tests for new case

Reason

This resolves a condition where REPLY itip message are not generated when a user responses to a event using a client like TB with client side responses disableb

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.76%. Comparing base (6eee31d) to head (49d53f1).
⚠️ Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
lib/ITip/Broker.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #743   +/-   ##
=========================================
  Coverage     98.76%   98.76%           
- Complexity     1876     1882    +6     
=========================================
  Files            71       71           
  Lines          5345     5281   -64     
=========================================
- Hits           5279     5216   -63     
+ Misses           66       65    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@SebastianKrupinski SebastianKrupinski force-pushed the fix/send-reply-on-event-creation branch from 154b7d0 to 49d53f1 Compare January 8, 2026 20:57
@ChristophWurst ChristophWurst merged commit b6d80d0 into sabre-io:master Jan 9, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants