Updated react version and moved to peer dependencies #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers bruno. I've actually no experience publishing modules for react, but I'll get this (and #1) fixed ASAP. |
|
Hey, Strange, tried changing the peerDependency to 0.12.2 but it gives me an error when installing on my project: "The package react does not satisfy its siblings' peerDependencies requirements!" It should match since I've put ^0.12.2 so it should match 0.13 http://stackoverflow.com/questions/22343224/difference-between-tilde-and-caret-in-package-json Gonna try some things out Cheers |
|
I think this is it, added peerDependency "react": ">= 0.12", and it now works in my project, can you confirm on yours as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using react already in a project, modules should have react in peerDependencies so that it doesn’t get included twice and uses the already included instance. Also updated React version, don’t know if you want that anyway decided to send a PR ;)