-
Notifications
You must be signed in to change notification settings - Fork 88
Upgrade ruby #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amolmjoshi93
wants to merge
18
commits into
develop
Choose a base branch
from
2037-upgrade-ruby-to-348-from-3310
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade ruby #2038
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f82403c
Upgrade
amolmjoshi93 a52279e
Fix security vulnerabilities and Docker image compatibility
amolmjoshi93 fd4fb39
Fix AWS initializer to check if Aws constant is defined
amolmjoshi93 4640c97
Update shakapacker to v9.5.0 and add required configuration
amolmjoshi93 0a815dd
Pin connection_pool to 2.x for react-rails compatibility
amolmjoshi93 cf0999a
Update shakapacker.yml for v9 compatibility
amolmjoshi93 1cc1ba4
Complete shakapacker v9 migration - remove webpacker references
amolmjoshi93 5228b46
Fix timeoff entry label format for zero days
amolmjoshi93 398bc34
Add webpack asset compilation step to CI workflow
amolmjoshi93 8b31acf
Bump Rails from 7.1.5.1 to 7.2.0
amolmjoshi93 a052ea2
fix: upgrade database_cleaner and configure Ferrum for Rails 7.2/Ruby…
amolmjoshi93 9f1f74d
fix: disable nested_entries in shakapacker config
amolmjoshi93 36bb7f3
Fix PDF test timeouts by mocking FerrumPdf browser initialization
amolmjoshi93 a08c090
Fix webpack config for shakapacker 9.x API change
amolmjoshi93 456cf12
Add missing babel-plugin-dynamic-import-node dependency
amolmjoshi93 a5fdef7
Removal of deprecation warnings and aftermath of rails upgrade
amolmjoshi93 a42ec83
fix: resolve DoubleRenderError, unsafe migration, and Docker version …
amolmjoshi93 22e015a
Fix Ruby 3.4.8 compatibility issues
amolmjoshi93 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.3.10 | ||
| 3.4.8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #syntax=docker/dockerfile:1 | ||
| FROM ruby:3.3.10-slim AS base | ||
| FROM ruby:3.4.8-slim AS base | ||
|
|
||
| ARG NODE_VERSION=20.18.2 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.