-
-
Notifications
You must be signed in to change notification settings - Fork 654
Add test for github format of doctest report #39512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit a50d918; changes) is ready! 🎉 |
It has always been like that, but looking at what the program prints out
a reasonable guess is the part being put after On the other hand in the downloaded log file only
would show up. This actually slightly inconvenience me in that I can't just download the log and parse it for the file and line number. (side note: There should probably be more tests for the |
Yes, it seems so. Thanks.
I agree. Maybe something to be improved later, if possible. |
this tests for whole-file timeout and failed example, although using unittest instead of command-line-based test. the long time warnings are tested in #40413, so this should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sagemathgh-39512: Add test for github format of doctest report As in the title. The feature was added in sagemath#36938 for the purpose of showing GitHub annotations for test failures, but there wasn't a doctest for it. This adds the test. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (no change to documentation preview because private method.) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39512 Reported by: user202729 Reviewer(s): Dima Pasechnik
sagemathgh-39512: Add test for github format of doctest report As in the title. The feature was added in sagemath#36938 for the purpose of showing GitHub annotations for test failures, but there wasn't a doctest for it. This adds the test. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (no change to documentation preview because private method.) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39512 Reported by: user202729 Reviewer(s): Dima Pasechnik
sagemathgh-39512: Add test for github format of doctest report As in the title. The feature was added in sagemath#36938 for the purpose of showing GitHub annotations for test failures, but there wasn't a doctest for it. This adds the test. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (no change to documentation preview because private method.) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39512 Reported by: user202729 Reviewer(s): Dima Pasechnik
As in the title.
The feature was added in #36938 for the purpose of showing GitHub annotations for test failures, but there wasn't a doctest for it. This adds the test.
📝 Checklist
⌛ Dependencies