Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/doc/en/developer/git_basic.rst
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,7 @@ Sometimes, a new version of Sage is released while you work on a Git branch.

Let us assume you started ``my_branch`` at commit ``B``. After a while, your
branch has advanced to commit ``Z``, but you updated ``develop`` (see
:ref:`section-git-pull-develop`) and now your Git history looks like this (see
:ref:`section_walkthrough_logs`):
:ref:`section-git-pull-develop`) and now your Git history looks like this:

.. CODE-BLOCK:: text

Expand Down
9 changes: 3 additions & 6 deletions src/doc/en/developer/review.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,16 @@ Anybody (e.g. you) can do this job for somebody else's PR. This document
lists things that the reviewer must check before deciding that a PR is
ready for inclusion into Sage.

You can now begin the review by reading the diff code.

**Check the GitHub checks:** We require all checks have passed.

**Read the diff:** Click "Files changed" tab of the PR. Read through the
changes of all modified files. We use `pull request reviews
<https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews>`_.
You can add comments directly to changed lines.

**Build the code:** (This is optional if the **build and test** check has passed.)
While you read the code, you can :ref:`rebuild Sage with the new code
<section-walkthrough-make>`. If you do not know how to **download the code**,
:ref:`see here <section-workflows-pr-checkout>`.
**Test the code:** (This is optional if the **build and test** check has passed.)
Checkout the **code of the PR** following :ref:`see here <section-workflows-pr-checkout>`
and run the relevant tests.

The following should generally be checked while reading and testing the code:

Expand Down
Loading
Loading