Skip to content

Add check for Arch Linux in configure to recommend meson build #40155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2025
Merged

Add check for Arch Linux in configure to recommend meson build #40155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0230ab
Add check for Arch Linux in configure to recommend meson build
tobiasdiez May 24, 2025
f1082a4
Move meson check further down
tobiasdiez May 24, 2025
42f173c
Don't fail on non-arch systems
tobiasdiez May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-linux-incremental.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ on:
paths:
- '.github/workflows/ci-linux-incremental.yml'
- 'build/pkgs/**'
- 'configure.ac'
- '!build/pkgs/sage_conf/**'
- '!build/pkgs/sage_docbuild/**'
- '!build/pkgs/sage_setup/**'
Expand Down
17 changes: 17 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,23 @@ AC_SUBST([SAGE_DOCS], ['${SAGE_LOCAL}'])dnl Quoted so that it is resolved at bui

#---------------------------------------------------------

# Check for systems where Meson build is recommended
AC_ARG_ENABLE([meson-check],
[AS_HELP_STRING([--disable-meson-check],
[do not fail the build if running on systems where Meson is preferred])],
[enable_meson_check=$enableval],
[enable_meson_check=yes])

if test "$enable_meson_check" != no; then
AC_MSG_CHECKING([for Arch Linux])
if grep -qi 'arch' /etc/os-release 2>/dev/null || test -f /etc/arch-release; then
AC_MSG_RESULT([yes])
AC_MSG_ERROR([Building on Arch Linux using make is not recommended. Please use Meson as described at https://doc.sagemath.org/html/en/installation/meson.html. Use --disable-meson-check to override.])
else
AC_MSG_RESULT([no])
fi
fi

AC_ARG_ENABLE([build-as-root],
[AS_HELP_STRING([--enable-build-as-root],
[allow building Sage as root (for use in containers)])],
Expand Down
Loading