Skip to content

Use the variable name τ instead of t for Drinfeld modules #40430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Jul 17, 2025

In the theory of Drinfeld module, the classical name of the noncommutative variable is τ. However, in Sage, we currently use t, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by t).
In this PR, we propose to shift to the notation τ. It just changes how the outputs are printed (by default), not the interface.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#40420, #40421

@mantepse
Copy link
Contributor

Will this affect copy & paste, to reuse output?

@kryzar
Copy link
Contributor

kryzar commented Jul 17, 2025

That's a fair question. In both the current state and the PR, the user has to instantiate a variable (t currently and τ in the PR).

τ is not on the keyboard, and in the docs we let tau be the variable (tau = phi.ore_variable()), but we suggest to do the following:

tau = τ = phi.ore_variable()

We acknowledge this is less convenient than the current state (the user has to do a copypasta), but t was a poorly named variable in the first place, as many people consider things such as $$t$$-motives...

@kryzar
Copy link
Contributor

kryzar commented Jul 17, 2025

(@mantepse: we're not sure what your thumb-up means!)

@mantepse
Copy link
Contributor

(@mantepse: we're not sure what your thumb-up means!)

It means that I am not against the proposed change.

@kryzar
Copy link
Contributor

kryzar commented Jul 17, 2025

In that case, I looked through each job fail and the culprits seem to be:

  • src/sage/libs/singular/function.pyx
  • mpfi
  • src/sage/rings/complex_arb.pyx

PR approved.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 18, 2025
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules
    
In the theory of Drinfeld module, the classical name of the
noncommutative variable is `τ`. However, in Sage, we currently use `t`,
which might conflict with other standard notations (often the variable
name of the underlying function ring is denoted by `t`).
In this PR, we propose to shift to the notation `τ`. It just changes how
the outputs are printed (by default), not the interface.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

sagemath#40420, sagemath#40421
    
URL: sagemath#40430
Reported by: Xavier Caruso
Reviewer(s): Antoine Leudière
@user202729
Copy link
Contributor

user202729 commented Jul 19, 2025

IPython tip: On a normal keyboard, you can type \tau<tab> to get τ.

If you're using some editor to edit a .sage file, yes you need something else.

p/s: maybe @kryzar want to review the new commit?

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 19, 2025

Great! Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants