-
-
Notifications
You must be signed in to change notification settings - Fork 636
Use the variable name τ instead of t for Drinfeld modules #40430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Will this affect copy & paste, to reuse output? |
That's a fair question. In both the current state and the PR, the user has to instantiate a variable (
tau = τ = phi.ore_variable() We acknowledge this is less convenient than the current state (the user has to do a copypasta), but |
(@mantepse: we're not sure what your thumb-up means!) |
It means that I am not against the proposed change. |
In that case, I looked through each job fail and the culprits seem to be:
PR approved. |
sagemathgh-40430: Use the variable name τ instead of t for Drinfeld modules In the theory of Drinfeld module, the classical name of the noncommutative variable is `τ`. However, in Sage, we currently use `t`, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted by `t`). In this PR, we propose to shift to the notation `τ`. It just changes how the outputs are printed (by default), not the interface. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40420, sagemath#40421 URL: sagemath#40430 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière
IPython tip: On a normal keyboard, you can type If you're using some editor to edit a p/s: maybe @kryzar want to review the new commit? |
Great! Thanks for the tip! |
In the theory of Drinfeld module, the classical name of the noncommutative variable is
τ
. However, in Sage, we currently uset
, which might conflict with other standard notations (often the variable name of the underlying function ring is denoted byt
).In this PR, we propose to shift to the notation
τ
. It just changes how the outputs are printed (by default), not the interface.📝 Checklist
⌛ Dependencies
#40420, #40421