Skip to content

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Sep 9, 2025

correct version constraints for pybind11, add gentoo package info for python-build

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase
Copy link
Member Author

dimpase commented Sep 9, 2025

to ensure smoother ride on Gentoo in particular

Copy link

github-actions bot commented Sep 9, 2025

Documentation preview for this PR (built with commit 3742ec6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase dimpase changed the title Buildmetadata fixes 10.8.beta2 Build metadata fixes 10.8.beta2 Sep 9, 2025
Copy link
Contributor

@orlitzky orlitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run ./bootstrap && ./configure in a very long time, but I'll take your word for it. I guess this could go wrong if you have pybind-3.0 but try to install scipy from the SPKG? Either way this is probably better for the people who are trying to use system python packages.

@dimpase
Copy link
Member Author

dimpase commented Sep 10, 2025

I haven't run ./bootstrap && ./configure in a very long time, but I'll take your word for it. I guess this could go wrong if you have pybind-3.0 but try to install scipy from the SPKG? Either way this is probably better for the people who are trying to use system python packages.

scipy says:

    # The upper bound on pybind11 is pre-emptive only

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 11, 2025
correct version constraints for pybind11, fix spkg-configure for python-
build

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#40797
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
@vbraun
Copy link
Member

vbraun commented Sep 12, 2025

With this the build fails at gmpy2 for me (after make distclean)

[spkg-install] Installing gmpy2-2.2.0a1
[spkg-install] /home/release/Sage/local/var/lib/sage/venv-python3.12.5/bin/python3: No module named build
[spkg-install] Warning: building with "python3 -m build --wheel --outdir=dist   ." failed.
[spkg-install] Retrying with "python3 -m build --wheel --outdir=dist --no-isolation --skip-dependency-check  .".
[spkg-install] /home/release/Sage/local/var/lib/sage/venv-python3.12.5/bin/python3: No module named build
[spkg-install] ***************************************************************************************************************************************************************************
[spkg-install] Error building a wheel for gmpy2-2.2.0a1
[spkg-install] ***************************************************************************************************************************************************************************
************************************************************************
Error installing package gmpy2-2.2.0a1
************************************************************************

@dimpase
Copy link
Member Author

dimpase commented Sep 12, 2025

@vbraun please post config.log for this build, or at least provide me an access to it

@dimpase
Copy link
Member Author

dimpase commented Sep 13, 2025

@vbraun - I suppose it might need #39364 - on which you stall, for some reason for like a month. Ping?

@vbraun
Copy link
Member

vbraun commented Sep 13, 2025

I don't think its specific to gmpy2, thats just the first package that fails. After that many other python packages will fail with the same error. Build is not installed or there is something wrong with the python path and it gets confused with the "build" directory.

@dimpase
Copy link
Member Author

dimpase commented Sep 13, 2025

Sorry, we just should revert 59df82b - it was OK without it.

@dimpase
Copy link
Member Author

dimpase commented Sep 14, 2025

the rest is totally non-controversial, setting to positive

@dimpase
Copy link
Member Author

dimpase commented Sep 14, 2025

On opensuse tumbleweed CI runs one gets 21.15 Package 'python310-setuptools' not found.
I guess it's due to python3${PYTHON_MINOR}-setuptools in build/pkgs/setuptools/distros/opensuse.txt - and apparently it's not right for umbleweed (not sure about other flavours of suse).

@dimpase
Copy link
Member Author

dimpase commented Sep 15, 2025

tests pass (there are 2 false positives). I move it back to positive review after a trivial rebase

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 16, 2025
sagemathgh-40797: Build metadata fixes 10.8.beta2
    
correct version constraints for pybind11, add gentoo package info  for
python-build

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40797
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 19, 2025
sagemathgh-40797: Build metadata fixes 10.8.beta2
    
correct version constraints for pybind11, add gentoo package info  for
python-build

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40797
Reported by: Dima Pasechnik
Reviewer(s): Michael Orlitzky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants