-
-
Notifications
You must be signed in to change notification settings - Fork 665
Build metadata fixes 10.8.beta2 #40797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
to ensure smoother ride on Gentoo in particular |
Documentation preview for this PR (built with commit 3742ec6; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run ./bootstrap && ./configure
in a very long time, but I'll take your word for it. I guess this could go wrong if you have pybind-3.0 but try to install scipy from the SPKG? Either way this is probably better for the people who are trying to use system python packages.
scipy says:
|
correct version constraints for pybind11, fix spkg-configure for python- build ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40797 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
With this the build fails at gmpy2 for me (after make distclean)
|
@vbraun please post config.log for this build, or at least provide me an access to it |
I don't think its specific to gmpy2, thats just the first package that fails. After that many other python packages will fail with the same error. Build is not installed or there is something wrong with the python path and it gets confused with the "build" directory. |
Sorry, we just should revert 59df82b - it was OK without it. |
a686b07
to
8764b92
Compare
the rest is totally non-controversial, setting to positive |
On opensuse tumbleweed CI runs one gets |
8764b92
to
3742ec6
Compare
tests pass (there are 2 false positives). I move it back to positive review after a trivial rebase |
sagemathgh-40797: Build metadata fixes 10.8.beta2 correct version constraints for pybind11, add gentoo package info for python-build ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40797 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
sagemathgh-40797: Build metadata fixes 10.8.beta2 correct version constraints for pybind11, add gentoo package info for python-build ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40797 Reported by: Dima Pasechnik Reviewer(s): Michael Orlitzky
correct version constraints for pybind11, add gentoo package info for python-build
📝 Checklist
⌛ Dependencies