Add every path in XDG_DATA_DIRS to sage_data_paths

[antonio-rojas]

Instead of just the first one.

[github-actions]

Documentation preview for this PR (built with commit f542401; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

[orlitzky]

Instead of duplicating the splitting, you could use for appname in (None, "sagemath")?

[antonio-rojas]

Instead of duplicating the splitting, you could use for appname in (None, "sagemath")?

You mean manually appending "sagemath" to every path? I find it simpler this way.

[orlitzky]

No... something like,

for appname in (None, "sagemath"):
    for path in site_data_dir(appname, multipath=True).split(os.pathsep):
        paths.add(path)

[antonio-rojas]

But that is still doing two splits? I'm missing the point of looping through a two item list.

[orlitzky]

To me it just makes it clear that you're running the same sequence of functions with two different arguments. It's not a big deal. Are any of those CI failures related, or are those the new perma-fails with this beta?

[antonio-rojas]

To me it just makes it clear that you're running the same sequence of functions with two different arguments. It's not a big deal. Are any of those CI failures related, or are those the new perma-fails with this beta?

It (the ubuntu one) has been there for a long time. It's a # long time test so it only shows up on PRs touching env.py. The other ones are unrelated.

[orlitzky]

ok, fine by me