Skip to content

fix(client): use the http client from the config when fetching the access token#107

Open
lol3909 wants to merge 1 commit intosailpoint-oss:mainfrom
lol3909:fix/use-http-client-from-config
Open

fix(client): use the http client from the config when fetching the access token#107
lol3909 wants to merge 1 commit intosailpoint-oss:mainfrom
lol3909:fix/use-http-client-from-config

Conversation

@lol3909
Copy link
Copy Markdown

@lol3909 lol3909 commented Aug 25, 2025

Description

Use the HTTP client from the configuration instead of using a brand new HTTP client.

I'm proposing this fix because in my code, I change the transport object in my unit test when I need to mock it. That works well except for this call that doesn't take the configured HTTP Client into consideration. Also, it is a common pattern in Go to let the user of a library overwrite the HTTP Client, so I don't see why we couldn't use it here too.

Also, I added to the make file all of the API versions that need to be built; I'm not sure why they weren't all there. Maybe I'm missing some context for that. Feel free to correct me 😁

This is my first time contributing to this repo. If I missed something, feel free to correct. Hope this fix helps!

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lol3909 lol3909 marked this pull request as ready for review August 25, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants