Draft
Conversation
Owner
|
Sorry for the long delay in responding to this - haven't had much time recently. This is great, thanks a lot. I'll leave it open for now until I have time to come back to the library in more depth, but it looks like this will be the core of how this feature gets added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an insanely hacky approach to implement reddit gallery support.
I'd advise against merging it as is, but consider it as a proof of concept how this could work.
A less hacky approach would probably incorporate https://github.com/mikf/gallery-dl
Related: #12