forked from gnolang/gno
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(lint): poc with transcribeB to add extensible rules #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MikaelVallenet
wants to merge
32
commits into
samouraiworld:master
Choose a base branch
from
MikaelVallenet:mikael/experiment/linter-archi-gno-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(lint): poc with transcribeB to add extensible rules #7
MikaelVallenet
wants to merge
32
commits into
samouraiworld:master
from
MikaelVallenet:mikael/experiment/linter-archi-gno-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly member storage (gnolang#4754) This PR removes the `MemberSet` type in favor of the `ReadonlyMemberStorage`, which is introduced with other grouping related readonly types. `MemberSet` was intended as a readonly representation for proposal definitions to read DAO members. CommonDAO now supports members grouping which should also be available to the proposal definitions to be able to tally votes in contexts where grouping is relevant for counting votes, and specially where direct access to CommonDAO instances is not possible, for example for proposal definitions defined in third party realms. Proposal definition's `Tally()` method now receives a single argument containing a readonly member storage instead of a member set and the readonly voting record: ```go func (ProposalDefinition) Tally(VotingContext) (bool, error) ``` The new `VotingContext` type is defined as: ```go // VotingContext contains current voting context, which includes a voting // record for the votes that has been submitted for a proposal and also // the list of DAO members. VotingContext struct { VotingRecord ReadonlyVotingRecord Members ReadonlyMemberStorage } ``` Readonly types are introduced to be able for proposal definitions implemented in third party realms to read relevant DAO information which might not be accessible directly to these realms. Member groups can be accessed from the member storage.
This PR targets the links on the Action page in gnoweb. It normalizes Anchor/Execute buttons URLs and unifies their dynamic parameter updates so both stay in sync when inputs change: - Use same-origin relative/absolute paths for Help links to avoid browser-relative resolution issues. - Unify client-side updates for both links (Execute `href` and Anchor `data-copy-text-value`) in one pass. - Fix TypeScript typing by avoiding possibly-undefined dataset values when building URLs. This will: - Prevents browser from treating gno.land/... as a relative path that gets appended to the current route (when the http protocol is missing). - Fix the url difference created by the browser between `href` and `dataset` (browser autocomplete href ones with full protocol url when missing) - Ensures the "Anchor" and "Execute" actions always reflect the same parameters.
# feat(web): form exec This PR introduces a new feature to the form ext in gnoweb (form exec). It enables dynamic form submission from the web interface to gnokey (and wallets in the end). This provides a more natural and consistent bridge between the front-end and the on-chain logic while staying in the render view. ## Main Changes - Added a new endpoint/handler to process form execution (it auto get the params after a function is set) - Updated the web layer to support form submission and async processing. - Updated the HTML/JS front-end to trigger form execution and display execution status (cmd). - Added/modified tests to cover the new form → exec flow. - add default value content param ## Next Steps Wallets will need to sync with this new form execution flow so they can intercept the form submission event and properly handle the transaction signing process. This PR only exposes the form; wallet integration should come next. <img width="826" height="534" alt="Capture d’écran 2025-10-27 à 10 56 29" src="https://github.com/user-attachments/assets/b0828bda-4cd0-4cf6-81fb-017ebac371a1" /> --------- Co-authored-by: Alexis Colin <[email protected]> Co-authored-by: Antoine Eddi <[email protected]> Co-authored-by: aeddi <[email protected]>
PR gnolang#3931 updates vm/qdoc to flag which functions are crossing. Update the gnoweb help page to support calling qeval for non-crossing functions. * For non-crossing functions, show the command as `gnokey query vm/qeval` (instead of `gnokey maketx`). The user can copy and paste to the command line. * Add function `_updateQEvalResult` which is called from `_pushArgsInDOM` each time that the param values are changed. If it's a non-crossing function and all the params have a value then use `fetch` to call `abci_query` and show the result. * In Content-Security-Policy, add `connect-src <remote>/abci_query` so that we can use fetch for `abci_query` <img width="999" height="355" alt="image" src="https://github.com/user-attachments/assets/5d5070a9-415e-4e46-9e60-32e49d5548df" /> --------- Signed-off-by: Jeff Thompson <[email protected]> Co-authored-by: alexiscolin <[email protected]>
Co-authored-by: Morgan <[email protected]>
Resolves gnolang#2737 As [required by the HID library](https://github.com/Zondax/hid/blob/148be243caa49724e017c248dde643b0ada03742/README.md?plain=1#L31), the executable must be built with `CGO_ENABLED=1` in order to find the Ledger. We want to keep building without this flag by default so that the binary is deterministic. The HID library already has the [`Supported` function](https://github.com/Zondax/hid/blob/148be243caa49724e017c248dde643b0ada03742/hid_disabled.go#L15) which returns false if not built with cgo. * In the `getLedgerDevice`, if not `Supported` then return an error message to try building with CGO_ENABLED=1 The error message looks like: ``` unable to create Ledger reference in keybase, ledger support is not enabled, try building with CGO_ENABLED=1 ``` This PR is a minimal solution as an alternative to putting `CGO_ENABLED=1` in the [gnokey Makefile](https://github.com/gnolang/gno/blob/e3df2c9e0bb17ddc90f34db223ab6593b4f6ca8a/gno.land/Makefile#L48). --------- Signed-off-by: Jeff Thompson <[email protected]> Co-authored-by: Antoine Eddi <[email protected]>
…ng#4877) Fixed incorrect operation order preventing re-upload of edited private packages. Also added a test case for this scenario. --------- Co-authored-by: Romain Gay <[email protected]> Co-authored-by: ltzmaxwell <[email protected]> Co-authored-by: Manfred Touron <[email protected]>
gnolang#4890) This PR will finalize the gno interrealm spec. The primary goal is to address the Oak security audit issue found. Also will unify terminology, and double-check consistency of interrealm spec. Making a PR to allow commenting on the initial commit of mental model. Related: https://github.com/gnolang/gno/security/advisories/GHSA-64hv-3ww9-mc3f --------- Signed-off-by: moul <[email protected]> Co-authored-by: Manfred Touron <[email protected]> Co-authored-by: ltzMaxwell <[email protected]> Co-authored-by: Morgan <[email protected]>
alternative to gnolang#2434 Taking into account some of the reviews on gnolang#2434 I tried to integrate traces first on gRPC server. This already works on a basic form but we still need to identify important places were to put the traces <img width="845" height="317" alt="image" src="https://github.com/user-attachments/assets/a5706ace-5244-460d-b858-0d60a38d70f4" /> Added more traces direclty on rpc handlers <img width="838" height="307" alt="image" src="https://github.com/user-attachments/assets/b160bc15-bbc8-47ea-96c4-9dfa336ea96a" /> <img width="825" height="105" alt="image" src="https://github.com/user-attachments/assets/6ae06502-1c0a-4dc8-8d5d-b093e1d07f16" />
Co-authored-by: Antoine Eddi <[email protected]>
Closes gnolang#4866 Required for gnolang#4655 Added a txtar test to ensure that -send flag doesnt affect the user balance when used in `maketx run`. Added similar txtar for `maketx call`, this time the user balance is affected. --------- Co-authored-by: Manfred Touron <[email protected]>
Do not remove this file. It is important information, and a canary file.
Of all places, /r/UFOResearch should not censor this kind of information. DO NOT DELETE THIS FILE, DO NOT TRUST ANYONE WHO DELETES THIS FILE.
added law of spinning mass.
…nolang#4926) Alternative for gnolang#4905 Kept: - Removed GetRaw/SetRaw since they were unused. - SetBytes to use directly the store, preventing the value to be aminoJSON encoded. Updated: - Preserve API consistency. --------- Signed-off-by: moul <[email protected]> Co-authored-by: Thomas Bruyelle <[email protected]>
Package aims to be a very simple package to define Gno-Flavored Markdown forms. It should be easy to update when new form elements or attributes are introduced. --------- Co-authored-by: Antoine Eddi <[email protected]>
longer term fix for gnolang#4874, re-introducing the type check cache for stdlibs.
…ng#4939) PR changes Boards2 realm to use `gno.land/p/gnoland/boards` package which makes the realm leaner. It also improves `BasicPermissions` implementation by using a custom members storage implementation that makes users iteration cheaper.
…g#4899) fix gnolang#4432 --------- Co-authored-by: Morgan <[email protected]>
Signed-off-by: moul <[email protected]> --------- Signed-off-by: moul <[email protected]> Co-authored-by: Antoine Eddi <[email protected]>
…g#4998) Also add a couple of minor fixes
…g#4978) Closes gnolang#4968 ## Description The `<gno-textarea>` component was literally displaying the `\n` sequence. After fix, the parser now interprets the `\n` sequence as a real newline character. ### Example ``` <gno-form> <gno-textarea name="content" value=" First line\nSecond line" /> </gno-form> ``` ### Before fix: <img width="931" height="236" alt="Capture d’écran 2025-12-15 à 23 22 23" src="https://github.com/user-attachments/assets/220f85ee-c5ad-4dd3-9b26-863bd84e6a58" /> ### After fix: <img width="945" height="239" alt="Capture d’écran 2025-12-15 à 23 34 27" src="https://github.com/user-attachments/assets/e8f7551e-749f-4259-ba50-5dae333cf487" /> --------- Co-authored-by: alexiscolin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.