Allow Hyrax to correctly handle sidebar menu - #1081
Merged
Merged
Conversation
laritakr
force-pushed
the
handle-sidebar-menu-partial-correctly
branch
from
November 22, 2025 00:18
9b28858 to
764cac5
Compare
Bulkrax is attempting to support multiple versions of Hyrax, some of which do not have the `sidebar_partials` method defined on `Hyrax::DashboardController`. To ensure compatibility, we need to check for the existence of this method before trying to use it. Previously, the code was still overriding Hyrax's partial, resulting in an incorrect sidebar menu display. By adding a conditional check, we can ensure that Bulkrax only modifies the view paths when necessary, thus allowing Hyrax to correctly handle the sidebar menu.
kirkkwang
approved these changes
Nov 22, 2025
orangewolf
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs: samvera/hyku#2796
Bulkrax is attempting to support multiple versions of Hyrax, some of which do not have the
sidebar_partialsmethod defined onHyrax::DashboardController. To ensure compatibility, we need to check for the existence of this method before trying to use it.Previously, the code was still overriding Hyrax's partial, resulting in an incorrect sidebar menu display. By adding a conditional check, we can ensure that Bulkrax only modifies the view paths when necessary, thus allowing Hyrax to correctly handle the sidebar menu.