-
Notifications
You must be signed in to change notification settings - Fork 52
🎁 Splash page styling and layout #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+86
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added splash.scss for splash page specific styles - Updated hyku.scss to import splash.scss - Styled jumbotron and product-features section for better visual appeal - Ensured button remains centered horizontally on all screen sizes - Added logo-hyku.png for branding on the splash page - Added spacing for product features
Test Results 3 files ±0 3 suites ±0 15m 11s ⏱️ -15s Results for commit 8d2ae96. ± Comparison against base commit 4c73226. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. |
kirkkwang
approved these changes
Dec 15, 2025
Collaborator
kirkkwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better!
Collaborator
|
Nice! |
ShanaLMoore
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved styling on the Hyku splash page.
Before: full screen
Before: mobile
After: full screen
After: mobile
@samvera/hyku-code-reviewers