Open
Conversation
orangewolf
approved these changes
Jun 6, 2024
Contributor
|
I don't think the pessimistic version constraint operator ( |
cjcolvar
reviewed
Sep 6, 2024
| spec.add_dependency 'valkyrie', '~> 3.0.1' | ||
| spec.add_dependency 'view_component', '~> 2.74.1' # Pin until blacklight is updated with workaround for https://github.com/ViewComponent/view_component/issues/1565 | ||
| spec.add_dependency 'sprockets', '~> 3.7' | ||
| spec.add_dependency 'sprockets', '~> 3.7.2' # Pin at 3.7.2 as 3.7.3 creates PermissionsControl error |
Member
There was a problem hiding this comment.
As @cudevmaxwell noted this will allow 3.7.3. How about restricting to 3.7.x less than 3.7.3?
Suggested change
| spec.add_dependency 'sprockets', '~> 3.7.2' # Pin at 3.7.2 as 3.7.3 creates PermissionsControl error | |
| spec.add_dependency 'sprockets', '~> 3.7', '< 3.7.3' # Pin below 3.7.3 because it creates a PermissionsControl error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6826
Summary
Pins sprockets at 3.7.2 on 4.x-stable branch