-
Notifications
You must be signed in to change notification settings - Fork 131
changed the color of the badge_color to a more compliant color for ac… #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessibility. as suggested by the WVU UI Developer (Jesse Griffis).
|
[celebrate] Christine Peterson reacted to your message:
…________________________________
From: Tracy McCormick ***@***.***>
Sent: Thursday, December 4, 2025 8:24:18 PM
To: samvera/hyrax ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [samvera/hyrax] changed the color of the badge_color to a more compliant color for ac… (PR #7304)
Fixes
Fixes #7108<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/issues/7108___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ZjdhMzoxMjYwMTY0MTBjMmVjYjU0OGNmMWFkOGIyYjNjM2RlODk0ZTIxNzBkM2Y5NjY0ZmJjYmRmYmZhMDZlZDY4OGUzOmg6VDpG> ; refs #7108<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/issues/7108___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6NjQzYTpkNDA1OTkzYTI3MmRmNzg2MzZkNWQwOTI0ZjBmMzZkZTkyNjg4Y2Y0MjNmY2JkNTQyNmM3NTA1ODkzMTYwMTcxOmg6VDpG>
Summary
Improve accessibility of the "User Collection" badge color to meet WCAG 2.2 AA contrast requirements.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
* The "User Collection" badge now uses color #007EA8 for improved contrast and accessibility.
* The badge color passes automated accessibility checkers (e.g., Siteimprove).
Type of change (for release notes)
notes-bugfix Bug Fixes
Detailed Description
This PR updates the badge color for the default "User Collection" type to ensure it meets accessibility standards:
* Changes the badge color from #0099cc to #007EA8 based on accessibility checker feedback.
* Aligns with recommendations in the issue report and UI review.
Changes proposed in this pull request:
* Update badge color for "User Collection" type in the collection type seeder.
@samvera/hyrax-code-reviewers<https://protect.checkpoint.com/v2/r01/___https://github.com/orgs/samvera/teams/hyrax-code-reviewers___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ZTc4ODphMjY0ODkwZTFiZTk3YTZjNWQ5NmIyODNmMzYzMGZmNjQ3NzBjNTQ4Yzc1NzZmNjhhMDgzZjRmNjBkMjZiMDdlOmg6VDpG>
________________________________
You can view, comment on, or merge this pull request online at:
#7304<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6OGQ3ZTpmZDI1Yjc2NTg0NDkxNTY3Yzg4MTliOTAyYWUxMjE3NTVlMmI2MGU5ZjFkZTAwMTk2ZmIzZjZhODAwNmM0ZjcwOmg6VDpG>
Commit Summary
* cfbb440<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304/commits/cfbb440f4cbec1467f3831c55bd90a97c3e5dc2e___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6OTY4NDo0MWY5YWM5ZjRkNGU5ZDI0MDg0NjlhOThjZTU4NmExYjhjY2NhMGM3MmExOTFiOGQ5MGJkZGIwNjk3ZTA2MWEzOmg6VDpG> changed the color of the badge_color to a more compliant color for accessibility. as suggested by the WVU UI Developer (Jesse Griffis).
File Changes
(1 file<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304/files___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6N2UxMDo0Yzg1NmQyZmFjMjMzOTlhODdjMjkzYzA2ZTM0YjEwMDBjY2RmNjYyODVmMDlhY2VjYzI0NDkwOWQzZjgwMDQ3Omg6VDpG>)
* M app/utils/hyrax/required_data_seeders/collection_type_seeder.rb<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304/files%23diff-0ec175ce0c6e158b624f92f20fffc2dcef5ab86f55d27884cfb5f5c1d055075a___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ZWM2MTphZWM0MjBkZWUyZjM3MDU0N2UzY2M3OTgyZDdhYmIzYTYyOGE5NDUyNDRkZTU5ZjlmMDA5NTQ0ODdmNGE2YTBiOmg6VDpG> (2)
Patch Links:
* #7304.patch<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304.patch___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ZGM1NToyNTFhOGRlMTcwZWIzNDVlY2ViZmU4ZTczMDVhYWE0YTExZjFkYzczYzIwZTEyNzBiZDc5YjkyYWQyMDc1YjRmOmg6VDpG>
* #7304.diff<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304.diff___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ODUwMzoyYWZlY2Y4NGVhZGMzOThkMGRmZGFhMDFiMTc1YWQ4ZTM5YTI4MTg2NzU1ZDFlMWIwMDA1YTZhZWJlZjM4Y2IyOmg6VDpG>
—
Reply to this email directly, view it on GitHub<https://protect.checkpoint.com/v2/r01/___https://github.com/samvera/hyrax/pull/7304___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6YjBiZDphZDdiZTViYzQ0MDI2ZGUzYjc3NWQyMWQ5Mjc4Mzg0MmEwYmNhYzBkMDdjYmVmNzc1ZGJiNTg3YzAzOGIyMDcwOmg6VDpG>, or unsubscribe<https://protect.checkpoint.com/v2/r01/___https://github.com/notifications/unsubscribe-auth/AC3AQ266CYD6V6DV4DIDUC34ACJ7FAVCNFSM6AAAAACOCQWBOOVHI2DSMVQWIX3LMV43ASLTON2WKOZTGY4TMNBQGY2TCNI___.YzJ1OmFtaWdvc2xpYnJhcnlzZXJ2aWNlczE6YzpvOjM5OWFiMDk3NjJhNDAwMmUyNDEzOTRjZmRkODgwMjgyOjc6ZTM4NjpmNjE1YWNmNmNlYmQwNDY3YWJkMzQ3OGI5Y2ZkYjllN2I5ZmVhOWIxZWU3MmEwNjE1NTQ2ZmEzNDhjOTNjZTQ2Omg6VDpG>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
cjcolvar
approved these changes
Dec 4, 2025
Member
cjcolvar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Test Results 13 files 13 suites 2h 50m 28s ⏱️ Results for commit cfbb440. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #7108 ; refs #7108
Summary
Improve accessibility of the "User Collection" badge color to meet WCAG 2.2 AA contrast requirements.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
notes-bugfixBug FixesDetailed Description
This PR updates the badge color for the default "User Collection" type to ensure it meets accessibility standards:
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers