Skip to content

Use textual labels for public catalog sort options #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkuehn-uofl wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −13
Open

Use textual labels for public catalog sort options #7402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .dassie/app/controllers/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,10 @@ def self.modified_field
# except in the relevancy case).
# label is key, solr field is value
config.add_sort_field "score desc, #{uploaded_field} desc", label: "relevance"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded \u25BC"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded \u25B2"
config.add_sort_field "#{modified_field} desc", label: "date modified \u25BC"
config.add_sort_field "#{modified_field} asc", label: "date modified \u25B2"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded (newest first)"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded (oldest first)"
config.add_sort_field "#{modified_field} desc", label: "date modified (newest first)"
config.add_sort_field "#{modified_field} asc", label: "date modified (oldest first)"

# If there are more than this many search results, no spelling ("did you
# mean") suggestion is offered.
Expand Down
8 changes: 4 additions & 4 deletions .koppie/app/controllers/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,10 @@ def self.modified_field
# except in the relevancy case).
# label is key, solr field is value
config.add_sort_field "score desc, #{uploaded_field} desc", label: "relevance"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded \u25BC"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded \u25B2"
config.add_sort_field "#{modified_field} desc", label: "date modified \u25BC"
config.add_sort_field "#{modified_field} asc", label: "date modified \u25B2"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded (newest first)"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded (oldest first)"
config.add_sort_field "#{modified_field} desc", label: "date modified (newest first)"
config.add_sort_field "#{modified_field} asc", label: "date modified (oldest first)"

# If there are more than this many search results, no spelling ("did you
# mean") suggestion is offered.
Expand Down
8 changes: 4 additions & 4 deletions lib/generators/hyrax/templates/catalog_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,10 @@ def self.modified_field
# except in the relevancy case).
# label is key, solr field is value
config.add_sort_field "score desc, #{uploaded_field} desc", label: "relevance"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded \u25BC"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded \u25B2"
config.add_sort_field "#{modified_field} desc", label: "date modified \u25BC"
config.add_sort_field "#{modified_field} asc", label: "date modified \u25B2"
config.add_sort_field "#{uploaded_field} desc", label: "date uploaded (newest first)"
config.add_sort_field "#{uploaded_field} asc", label: "date uploaded (oldest first)"
config.add_sort_field "#{modified_field} desc", label: "date modified (newest first)"
config.add_sort_field "#{modified_field} asc", label: "date modified (oldest first)"

# If there are more than this many search results, no spelling ("did you
# mean") suggestion is offered.
Expand Down
2 changes: 1 addition & 1 deletion spec/features/collection_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@

expect(page).to have_css(".pagination")

select('date modified ▲', from: 'Sort')
select('date modified (oldest first)', from: 'Sort')
click_button 'Refresh'

expect(page).to have_text(/Test Resource 0.+1.+2.+3.+4.+5.+6.+7.+8.+9/m)
Expand Down
Loading