Conversation
Fix index_field_label crash when label is a lambda without custom_label #7390 introduced display_label_for, which sets field_config.label to a locale-deferred lambda. The existing guard only invoked lambdas when custom_label was truthy, so .match(/\./) was called directly on the Proc, raising NoMethodError. Added an unconditional respond_to?(:call) guard before the .match check.
Test Results 17 files ±0 17 suites ±0 3h 25m 10s ⏱️ - 3m 6s Results for commit e52912d. ± Comparison against base commit d3e4d89. This pull request removes 444 and adds 446 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
dlpierce
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix index_field_label crash when label is a lambda without custom_label
#7390 introduced display_label_for, which sets field_config.label to a locale-deferred lambda. The existing guard only invoked lambdas when custom_label was truthy, so .match(/./) was called directly on the Proc, raising NoMethodError.
Added an unconditional respond_to?(:call) guard before the .match check.