Skip to content

Add ahead tests #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jun 5, 2025
Merged

Add ahead tests #113

merged 39 commits into from
Jun 5, 2025

Conversation

ikalash
Copy link
Collaborator

@ikalash ikalash commented May 24, 2025

This PR adds a number of new tests for the AHEAD problems. A few things to be aware of:

  • All tests pass on Irina's RHEL9 machine, hayka. I am not sure what will happen in the nightly test harness. It is possible that some of the test tolerance need to be loosened a bit for all tests to pass there. We can see what happens when they run.
  • All the new Schwarz test compare the number of Schwarz iterations needed for convergence with a reference array of these values. This means that if a change is introduced that doesn't change the solution but changes the # Schwarz iterations, a test will fail and needs to be rebaselined. I would like to keep this behavior b/c I want us to be aware if we make a change that changes the # Schwarz iterations, whether for the good or bad.
  • It takes about 32 mins on Irina's machine to run all tests. Many users will not be patient enough for this. Some tests can be moved to the longer test category. I will let @lxmota do this after this is merged in based on any criteria he has for how fast the core tests should run.
  • There are still some tests that need to be added for full coverage; see the comments of Add tests for AHEAD problems #99 . I will work on this when I'm back from foreign travel.

ikalash added 30 commits May 17, 2025 18:19
Writing plate test for overlapping Schwarz.
@ikalash ikalash requested a review from lxmota May 24, 2025 01:39
@lxmota
Copy link
Collaborator

lxmota commented May 24, 2025

There seem to be conflicts because both the ubuntu and macos tests fail. I'll try to checkout this branch separately and resolve the conflicts.

@ikalash
Copy link
Collaborator Author

ikalash commented May 24, 2025

Thanks @lxmota . It could be a tolerance issue - I did specify very tight tolerances. I am not going to have time to look at this now b/c I am flying out tomorrow morning. It would be great if these could get fixed/merged in so that when you/others check things in, the ahead tests will be run.

@lxmota
Copy link
Collaborator

lxmota commented May 24, 2025

Yes, I see that some tolerances are too tight. I’ll take a look.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.45%. Comparing base (b02a962) to head (6c079f0).
Report is 40 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   93.42%   93.45%   +0.02%     
==========================================
  Files          16       16              
  Lines        3956     3956              
==========================================
+ Hits         3696     3697       +1     
+ Misses        260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ikalash
Copy link
Collaborator Author

ikalash commented Jun 5, 2025

CI tests are clean so I will merge in.

@ikalash ikalash merged commit c3e0966 into main Jun 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants