-
Notifications
You must be signed in to change notification settings - Fork 5
Add ahead tests #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ahead tests #113
Conversation
Writing plate test for overlapping Schwarz.
There seem to be conflicts because both the ubuntu and macos tests fail. I'll try to checkout this branch separately and resolve the conflicts. |
Thanks @lxmota . It could be a tolerance issue - I did specify very tight tolerances. I am not going to have time to look at this now b/c I am flying out tomorrow morning. It would be great if these could get fixed/merged in so that when you/others check things in, the ahead tests will be run. |
Yes, I see that some tolerances are too tight. I’ll take a look. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 93.42% 93.45% +0.02%
==========================================
Files 16 16
Lines 3956 3956
==========================================
+ Hits 3696 3697 +1
+ Misses 260 259 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CI tests are clean so I will merge in. |
This PR adds a number of new tests for the AHEAD problems. A few things to be aware of: