Adding Pressure NBC to Norma #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set BC value only for normal component of solution for pressure NBC.
Adding multiplication of prescribed value with unit normal. Something is wrong based on computed solution, so need to debug. Changing pressure NBC test case to just have 1 element to simplify debugging.
… struct." This reverts commit a5e8b31.
There is an issue with sizes/indices that needs to be debugged.
Code runs now but I think there are still issues based on looking at the solution. Need to do more testing.
not producing correct result.
Checking in test for this new capability. Still need to check behavior for dynamic problem and write dynamic test. Also need to verify that PNBC works correctly for more sophisticated problems.
|
@lxmota : can I merge this, or you want to wait until the failing tests are fixed? The failing tests are not related to this branch, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Pressure NBC to Norma, and a corresponding quasistatic test.
Still need to do further testing of Pressure NBC and to write a dynamic test, but creating a PR to be merged now per @lxmota 's request.