Skip to content

à la carte standard GST reports, and exception handling for computing metrics #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

rileyjmurray
Copy link
Contributor

@rileyjmurray rileyjmurray commented Jul 25, 2025

Generating a standard report can take an excessively long time. It's also possible for uncaught exceptions to be raised in the report generation process. This PR addresses both of those issues, by

  1. Adding a skip_sections argument to construct_standard_report (see docs for explanation of its behavior), and
  2. Adding exception handling to many (most?) modelmember metrics that might raise linear algebra errors or dimensional errors.

This PR also replaces instances of numpy.NaN with numpy.nan, for compatibility with numpy 2.0.

This splits out work from PR #410. Once this is merged into develop, I'll rebase PR #410 from that point of develop.

@rileyjmurray rileyjmurray marked this pull request as ready for review July 25, 2025 17:11
@rileyjmurray rileyjmurray requested review from a team and adhumu as code owners July 25, 2025 17:11
Copy link
Contributor

@coreyostrove coreyostrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look good to me, thank you for your work, @rileyjmurray! We're asymptotically approaching the more resilient report generation we highlighted as a goal in #299. Please feel free to merge this in upon the final set of unit tests completing (assuming they have passed).

@rileyjmurray rileyjmurray merged commit 341b279 into develop Jul 25, 2025
4 checks passed
@rileyjmurray rileyjmurray mentioned this pull request Jul 25, 2025
@coreyostrove coreyostrove added this to the 0.9.14 milestone Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants