-
Notifications
You must be signed in to change notification settings - Fork 59
Mirror circuit fidelity estimation support and introduction of benchmarking interface (name TBD) #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror circuit fidelity estimation support and introduction of benchmarking interface (name TBD) #628
Changes from 41 commits
3093bc2
d2b1137
88a267e
b89d1e2
40b5711
a48f2c2
57a7e67
515a7e8
7afd5e2
a5e5750
45bea5d
0d66a82
57c7853
9ad4941
b696de9
c91b04f
18cf81d
959468e
343643e
6e5d5b9
c78453c
7ff81c6
5fc09e7
ce59e72
664436b
bd1428a
1c73dbf
0c36554
d071a75
e459412
02cbc33
dcb5cbe
91a2f7d
714d8d0
7bbed14
e9ae6d1
3816743
d6b6491
919b398
57239e6
bc723b4
9533e83
d248d98
2dbdd55
e418630
59ec70f
442d8b0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1893,7 +1893,7 @@ def to_native(self): | |
""" | ||
return tuple(self) | ||
|
||
def replacename(self, oldname, newname): | ||
def replace_name(self, oldname, newname): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Every other class that inherits from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! |
||
""" | ||
Returns a label with `oldname` replaced by `newname`. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -878,7 +878,7 @@ def subgraph(self, nodes_to_keep, reset_nodes=False): | |
qubit_labels = nodes_to_keep | ||
|
||
edges = [] | ||
for edge in self.edges(): | ||
for edge in self.edges(include_directions=True): | ||
|
||
if edge[0] in nodes_to_keep and edge[1] in nodes_to_keep: | ||
if reset_nodes: | ||
edges.append((labelmap[edge[0]], labelmap[edge[1]])) | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is hard to add this comment inline, but you have a cell in this example notebook under the heading "Compute process fidelity for each circuit" which contains a bunch of postprocessing functions which ultimately return a pandas dataframe with the estimate process fidelities. Is the functionality of these helper function implemented in pyGSTi proper? You mentioned in the PR notes a new method for VBDataFrame which sounded like it would superficially produce a comparable output to your helper functions.