Skip to content

Saving endpoint DNS to config #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2025
Merged

Saving endpoint DNS to config #95

merged 7 commits into from
Jul 30, 2025

Conversation

ntozaks
Copy link
Contributor

@ntozaks ntozaks commented Jul 23, 2025

If a DNS name is specified as an endpoint during configure, the DNS name gets stored in the configuration file. Name resolution occurs during serve.

Addresses issue #87

@Aptimex
Copy link
Collaborator

Aptimex commented Jul 23, 2025

Initial test in the demo environment does not seem to be working, endpoint hostname is still getting resolved to an IP address immediately during configuration.

./wiretap configure -e wiretap-client-1:51820 -r 10.2.0.0/16
...
server command:
POSIX Shell:  ... WIRETAP_RELAY_PEER_ENDPOINT=10.1.0.2:51820 ...
cat wiretap_server.conf
[Relay.Interface]
PrivateKey = [...]
Port = 51820

[Relay.Peer]
PublicKey = [...]
Endpoint = 10.1.0.2:51820

@ntozaks
Copy link
Contributor Author

ntozaks commented Jul 23, 2025

The logic that I'm using to check for DNS doesn't account for numbers in the name. I will go back and fix that.

@Aptimex
Copy link
Collaborator

Aptimex commented Jul 23, 2025

Seems to be working now with configure -e, but the server fails to start with an error when configure -o wiretap-server-1:51820 is used.

@Aptimex Aptimex merged commit 42a590c into sandialabs:main Jul 30, 2025
1 check passed
@ntozaks ntozaks deleted the iss87 branch August 4, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants